On Fri, May 05, 2006 at 07:45:52AM +0200, Jes Sorensen wrote: > Randy.Dunlap wrote: > >On Thu, 4 May 2006 18:09:45 -0500 (CDT) Brent Casavant wrote: > > > >>Move various QLogic, Vitesse, and Intel storage > >>controller PCI IDs to the main header file. > >> > >>Signed-off-by: Brent Casavant <bcasavan@xxxxxxx> > >> > >>--- > >> > >>As suggested by Andrew Morton and Jes Sorenson. > > > >as compared to: > >http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9b860b8c4bde5949b272968597d1426d53080532 > > I guess Andrew and I should be blamed for that. I Andrew suggested > putting the IDs in the 'right place' and I took the right place as being > the pci_ids.h file. > > Can't say I agree with the recommendation, having them in pci_ids.h is > nice and clean and it allows one to go look through the list, instead > they now really become random hex values :( Brent's patch is a perfect > example of IDs being used in multiple places, ie. the qla1280 driver > and in the IOC4 driver, so the claim in that Documentation/ file doesn't > hold water. > > Anyway, if this is the new rule, then I guess it's back to using the > ugly patch :( No, I agree with your patch, as you are having to reference the ids from 2 different files. So because of that, I feel it's ok to have those ids in the pci_id.h file. Yes, the wording in the documentation file should be cleaned up a bit to state this a bit better... thanks, greg k-h - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
