Re: [PATCH] Fix a logic error in ahci_init_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2006-04-14 at 04:47 -0400, Jeff Garzik wrote:
> zhao, forrest wrote:
> > Fix an bug in error handling, also variable
> > pci_dev_busy has no use, remove it.
> > 
> > Signed-off-by: Zhao Forrest <forrest.zhao@xxxxxxxxx>
> 
> What logic error do you see?
> 
> pci_dev_busy has a clear use, as illustrated by the code:  if the PCI 
> regions are reserved by another device, the device is in use, therefore 
> we should avoid killing the device with pci_disable_device().
> 
> 	Jeff

Oh, one PCI device can be probed by multiple drivers. It's first
time for me to meet such case.
Please forgive my ignorance.

Forrest
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux