ata_eh_schedule_port() is the gateway to EH and does one of the
followings depending on how it's invoked.
* Without any flag: It simply schedules EH. EH will kick in after all
commands are drained (unless another event occurs, of course).
* ATA_EH_ABORT: EH is scheduled and all currently active qc's get
aborted. The caller is responsible for making sure the controller
and devices are in stable state in this case.
* ATA_EH_FREEZE: It does everything ATA_EH_ABORT does and then freezes
the port; thus, making the port inaccessible until it gets reset.
This can be used to safely schedule EH when an HSM violation event
occurs.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---
drivers/scsi/libata-core.c | 1 +
drivers/scsi/libata-eh.c | 53 ++++++++++++++++++++++++++++++++++++++++++++
include/linux/libata.h | 5 ++++
3 files changed, 59 insertions(+), 0 deletions(-)
a46608a256d68fd1e1e68a3e73f0be45c752c6a8
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 2a5d3f6..b6f6815 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -5300,5 +5300,6 @@ EXPORT_SYMBOL_GPL(ata_scsi_device_resume
EXPORT_SYMBOL_GPL(ata_scsi_error);
EXPORT_SYMBOL_GPL(ata_eng_timeout);
+EXPORT_SYMBOL_GPL(ata_eh_schedule_port);
EXPORT_SYMBOL_GPL(ata_eh_qc_complete);
EXPORT_SYMBOL_GPL(ata_eh_qc_retry);
diff --git a/drivers/scsi/libata-eh.c b/drivers/scsi/libata-eh.c
index a1fe14f..e731c04 100644
--- a/drivers/scsi/libata-eh.c
+++ b/drivers/scsi/libata-eh.c
@@ -239,6 +239,59 @@ void ata_eh_schedule_qc(struct ata_queue
scsi_eh_schedule_cmd(qc->scsicmd);
}
+/**
+ * ata_eh_schedule_port - schedule error handling without a qc
+ * @ap: ATA port to schedule EH for
+ * @flags: ATA_EH_* flags
+ *
+ * Schedule error hanlding for the speficied ATA port. EH will
+ * kick in as soon as all commands are drained.
+ *
+ * LOCKING:
+ * spin_lock_irqsave(host_set lock)
+ */
+void ata_eh_schedule_port(struct ata_port *ap, unsigned int flags)
+{
+ int internal_cmd = ata_tag_internal(ap->active_tag);
+ int i;
+
+ WARN_ON(!ap->ops->error_handler);
+
+ /* SHOST_RUNNING test is to avoid invoking EH during boot probing */
+ if (!internal_cmd && ap->host->shost_state == SHOST_RUNNING)
+ scsi_eh_schedule_host(ap->host);
+
+ /* abort if requested */
+ if (!(flags & (ATA_EH_ABORT | ATA_EH_FREEZE)))
+ return;
+
+ for (i = 0; i < ATA_MAX_QUEUE; i++) {
+ struct ata_queued_cmd *qc = ata_qc_from_tag(ap, i);
+ if (qc) {
+ if (!internal_cmd)
+ ata_eh_schedule_qc(qc);
+ else {
+ qc->flags |= ATA_QCFLAG_FAILED;
+ __ata_qc_complete(qc);
+ }
+ }
+ }
+
+ /* freeze if requested */
+ if (!(flags & ATA_EH_FREEZE))
+ return;
+
+ /* Timeout handler might try to freeze an already frozen port
+ * if it races against interrupt handler or another timeout.
+ * Such conditions should be rare. Whine.
+ */
+ if (ap->flags & ATA_FLAG_FROZEN && ata_ratelimit())
+ printk(KERN_INFO "ata%u: ata_eh_schedule_port invoked on "
+ "a frozen port\n", ap->id);
+
+ ata_port_freeze(ap);
+}
+
static void ata_eh_scsidone(struct scsi_cmnd *scmd)
{
/* nada */
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 8aeead3..47fbd68 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -222,6 +222,10 @@ enum {
ATA_PORT_PRIMARY = (1 << 0),
ATA_PORT_SECONDARY = (1 << 1),
+ /* flags for ata_eh_shduled_port */
+ ATA_EH_ABORT = (1 << 0), /* abort all active commands */
+ ATA_EH_FREEZE = (1 << 1), /* freeze port (implies ABORT) */
+
/* how hard are we gonna try to probe/recover devices */
ATA_PROBE_MAX_TRIES = 3,
};
@@ -653,6 +657,7 @@ extern unsigned long ata_pci_default_fil
*/
extern int ata_scsi_error(struct Scsi_Host *host);
extern void ata_eng_timeout(struct ata_port *ap);
+extern void ata_eh_schedule_port(struct ata_port *ap, unsigned int flags);
extern void ata_eh_qc_complete(struct ata_queued_cmd *qc);
extern void ata_eh_qc_retry(struct ata_queued_cmd *qc);
--
1.2.4
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
