Jeff Garzik wrote: > > Two comments: > > * I would like to find a device that's compliant with the spec, and test > the patch, before committing. I'm trying to get an Acard AEC-7900A and a Sunplus 3811A (which looks like a SiI 3811 rebrand) for test. Since the DMADIR is SiImage's idea, hopefully the Sunplus 3811A may support DMADIR. For bridges from other vendors, I guess the chance is low. > > * DMADIR not only includes a bit flag indicating its presence, it also > moves all the DMA capability bits from their standard places. You'll > have to audit every place that reads dev->id[]'s mwdma/udma masks and > make sure they look at the DMADIR-special-case location, when DMADIR is > set. > Fortunately only ata_id_xfermask() uses the mwdma/udma bits. Revised patch to follow. Thanks for the advice. -- albert - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
