Albert Lee wrote:
Handle DRQ=1 ERR=1 situation. Revised according to what IDE try_to_flush_leftover_data() does.
Changes:
- For ATA PIO writes and ATAPI devices, just stop the HSM and let EH handle it.
- For ATA PIO reads, read only one block of junk data and then let EH handle it.
Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx>
---
Thanks for the IDE try_to_flush_leftover_data() pointer.
The difference between IDE and irq-pio (before this patch):
1. IDE only does the data transfer for PIO reads.
For PIO writes and ATAPI, it just stops and abort/reset.
2. For PIO reads, only one block of data is transferred. EH then takes over if DRQ is still set after that.
The behavior of irq-pio before this patch is: let HSM go on, until the device set DRQ=0 or all data read.
Te IDE behavior looks safer. (When the device is in bad status, we really should not
write any data to it.)
Patch against irq-pio branch (08a556db919f67e1e4d33ae8d40f7222da34d994).
For your review, thanks.
applied
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
