Christoph Hellwig wrote: > On Tue, Mar 28, 2006 at 04:17:18PM -0600, Brian King wrote: >> Add a max_cmd_len field to the scsi_device struct >> to allow for per device limits of allowable command >> lengths. This will be used by libata, which is currently >> using the max_cmd_len field in the scsi_host struct, >> which doesn't work for attaching libata controlled >> SATA devices to SAS HBAs. > > this sounds wrong to me. cdb length is a limitation of the host (driver). > A target will reject unknown commands, no matter what length they have. In that case, this patch can probably be dropped. Currently libata has some code that looks at all the devices attached to a port and sets the scsi_host's max_cmd_len to the max of these values. I was assuming this was due to some misbehaving ATA/ATAPI devices out there. Jeff, care to comment on this one? -- Brian King eServer Storage I/O IBM Linux Technology Center - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
