On 3/27/06, Sergei Shtylylov <sshtylyov@xxxxxxxxxxxxx> wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > On 3/27/06, Sergei Shtylylov <sshtylyov@xxxxxxxxxxxxx> wrote: > > [skipped] > > >>>please fix siimage.c and core code instead > >>>(please see libata-core.c and ata_host_stop() etc.) > > >>>>- release the same number of DMA I/O ports that was requested by a driver > > >>>please fix trm290.c to use ->mmio == 2 instead > > >> It's a _really_ old chipset (pre SFF-8038i) and has _no_ memory mapped > >>regs AFAIK... > > > ->mmio == 2 means _only_ that host driver is responsible > > for reserving/releasing resources - it doesn't mean that host driver > > is using MMIO (a bit confusing but this is what the current code does) > > So, your point is that ide_setup_dma() should _never_ do anything for the > (mmio == 2) case? Maybe it shouldn't even be called? I guess we surely need No, my point is that for ->mmio == 2 core code may not try to manage IO or MMIO resources, only that. ide_setup_dma() call is still needed for calling ide_allocate_dma_engine() and setting up ->dma_* / ->ide_dma_* fields. > some driver cleanup hook to call ftom ide_release_dma()... Yep. Bartlomiej - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
