Tejun Heo wrote:
This patch renames ata_dev_present() to ata_dev_enabled() and adds ata_dev_disabled() and ata_dev_present(). This is to discern the state where a device is present but disabled from not-present state. This disctinction is necessary when configuring transfer mode because device selection timing must not be violated even if a device fails to configures. Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
OK in general, but NAK for transition reasons: this invites silent breakage of code not yet in #upstream, because ata_dev_present() implementation changes but the function signature does not. If a new ata_dev_present() is to be introduced, either a different name should be chosen, or the function signature should change such that an older user of the API will see a compiler warning or error.
Jeff - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
