Tejun Heo wrote:
ata_bus_softreset() should return AC_ERR_* on failure not arbitrary
positive number. While at it, kill trailing indentations and reformat
comment.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index f3c115b..200198c 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1999,13 +1999,12 @@ static unsigned int ata_bus_softreset(st
*/
msleep(150);
-
- /* Before we perform post reset processing we want to see if
- the bus shows 0xFF because the odd clown forgets the D7 pulldown
- resistor */
-
+ /* Before we perform post reset processing we want to see if
+ * the bus shows 0xFF because the odd clown forgets the D7
+ * pulldown resistor
+ */
if (ata_check_status(ap) == 0xFF)
- return 1; /* Positive is failure for some reason */
+ return AC_ERR_OTHER;
agreed and will apply, though note:
The reason Alan did this is most likely because the only other function
that produces a non-zero return code is ata_bus_edd->ata_busy_sleep,
which returns 1.
Though really, we should rip out E.D.D. anyway....
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
