On Llu, 2006-03-13 at 15:12 +0900, Tejun Heo wrote: > callback can be added later when merging PATA code. One concern I > have about the originally proposed ->mode_filter(ap, dev, mask, shift) > interface is that if a LLDD wants to reject all UDMA and limit some of > MWDMA, there is no way to do so. I think it's better and easier to > filter all mode masks at once. The current code is called three times once for PIO once for MWDMA and once for UDMA (since we don't do SWDMA yet). Doing it as one seems sensible enough, it just didn't fit how the old code worked. I also agree strongly we need ap-> and dev-> masks in the same format throughout libata and the drivers or there are going to be disasters - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
