On Sun, Mar 12, 2006 at 01:37:26PM +0000, Alan Cox wrote: > On Sul, 2006-03-12 at 16:02 +0900, Tejun Heo wrote: > > I marked with comment where the mode filtering for low level drivers > > should be done but I'm not sure how the interface should look like. > > Currently the libata pata patch code calls a filter function if present > which returns an updated bitmap for the mode type. I did that because we > need to combine the cable, bridge, core and chip specific rules neatly > and not have one forcing a mode the other cannot do. Understood. > > ->pre_set_mode(ap) is okay but then the LLDD should iterate over all > > devices. Maybe ->pre_set_mode(ap, dev) or ->filter_xfer_mask(ap, dev)? > > Providing > > 1. The proposed speeds are set for both devices on the cable before the > call. > 2. We reselect the speed of both devices on changedown or hotplug > > then we should be just fine. Yeap, both will hold. I'll just leave it as it is such that filtering callback can be added later when merging PATA code. One concern I have about the originally proposed ->mode_filter(ap, dev, mask, shift) interface is that if a LLDD wants to reject all UDMA and limit some of MWDMA, there is no way to do so. I think it's better and easier to filter all mode masks at once. Thanks. -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
