Re: [PATCH 2/6] sata_sil: kill bogus PCI ID 0x1095/0x0240

[Tejun Heo <htejun@xxxxxxxxx>]

Jeff Garzik wrote:
> Tejun Heo wrote:
>
> > Silicon Image confirmed that 0x1095/0x0240 has never been used for
> > 3112.  Kill it.
> >
> > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> > Cc: Carlos Pardo <Carlos.Pardo@xxxxxxxxxxxxxxxx>
> >
> > ---
> >
> >  drivers/scsi/sata_sil.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > 4c960f8b73294d01b9307ea6775304fc8556e550
> > diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
> > index 8cb662d..0d962a4 100644
> > --- a/drivers/scsi/sata_sil.c
> > +++ b/drivers/scsi/sata_sil.c
> > @@ -90,7 +90,6 @@ static void sil_post_set_mode (struct at
> >  
> >  static const struct pci_device_id sil_pci_tbl[] = {
> >      { 0x1095, 0x3112, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 },
> > -    { 0x1095, 0x0240, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 },
> >      { 0x1095, 0x3512, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3512 },
> >      { 0x1095, 0x3114, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3114 },
> >      { 0x1002, 0x436e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 },
>
>
>
> These things just don't get made up out of thin air.  I'm wonder if it 
> applies to a Silicon Image product running under a proprietary driver, 
> or OEM product with a bunch of SiI chips on it.  In any case, I'm 
> reluctant to remove it.

Agreed.

--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html