On Tue, Feb 28, 2006 at 01:12:38PM -0500, Jeff Garzik wrote: > Tejun Heo wrote: > >Now that libata is smart enought to handle both soft and hard resets, > >add softreset method. > > > >Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > ACK, finally > > (though I am dropping all your other pending patches as requested) > Good, and I forgot to resend the regenerated patches after writing I would do that ASAP. I was about to do that but then quilt2git didn't work and, after fixing it, I completely forgot why I fixed quilt2git in the first place. Duh... Will send soon. > > >+ /* spec says at least 5us, but be generous and sleep for 1ms */ > >+ msleep(1); > > FWIW msleep simply guarantees a minimum delay. Depending on the > scheduler tick granularity, msleep(1) may delay 10-100ms. > > This FWIW may or may not warrant updating the above comment, I leave it > up to you. > I think the comment is okay as it is and, more importantly, it wouldn't fit in one line with any more detail. :-P -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
