Re: [PATCH] ahci: add softreset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun Heo wrote:
Now that libata is smart enought to handle both soft and hard resets,
add softreset method.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

ACK, finally

(though I am dropping all your other pending patches as requested)


+	/* spec says at least 5us, but be generous and sleep for 1ms */
+	msleep(1);

FWIW msleep simply guarantees a minimum delay. Depending on the scheduler tick granularity, msleep(1) may delay 10-100ms.

This FWIW may or may not warrant updating the above comment, I leave it up to you.

	Jeff


-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux