On Tue, 28 Feb 2006, Tejun Heo wrote: > Kill kfree(id) in failure path of ata_dev_read_id(). id is not > dynamically allocated yet. > > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> matches my patch. > --- > > That was a leftover from patch reordering. > > Jeff, I'll regenerate patches #3-6 of reorganize ata_dev_identify() > patchset ASAP. So, at the moment, there's no pending patch waiting > for your review. > > Sorry. > > Index: work/drivers/scsi/libata-core.c > =================================================================== > --- work.orig/drivers/scsi/libata-core.c 2006-02-28 17:25:39.000000000 +0900 > +++ work/drivers/scsi/libata-core.c 2006-02-28 17:33:05.000000000 +0900 > @@ -1036,7 +1036,6 @@ static int ata_dev_read_id(struct ata_po > err_out: > printk(KERN_WARNING "ata%u: dev %u failed to IDENTIFY (%s)\n", > ap->id, dev->devno, reason); > - kfree(id); > return rc; > } > > - > : send the line "unsubscribe linux-ide" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- ~Randy - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
