On Tue, 28 Feb 2006 12:58:58 +0100
Pavel Machek <pavel@xxxxxx> wrote:
> Hi!
>
> > From: Randy Dunlap <randy_d_dunlap@xxxxxxxxxxxxxxx>
> >
> > Add ability for SCSI drivers to invoke a shutdown method.
> > This allows drivers to make drives safe for shutdown/poweroff,
> > for example. Some drives need this to prevent possible problems.
> >
> > Signed-off-by: Randy Dunlap <randy_d_dunlap@xxxxxxxxxxxxxxx>
>
> > --- linux-2616-rc4-ata.orig/drivers/scsi/scsi_sysfs.c
> > +++ linux-2616-rc4-ata/drivers/scsi/scsi_sysfs.c
> > @@ -302,11 +302,27 @@ static int scsi_bus_resume(struct device
> > return err;
> > }
> >
> > +static void scsi_bus_shutdown(struct device * dev)
> > +{
> > + struct scsi_device *sdev = to_scsi_device(dev);
> > + struct scsi_host_template *sht = sdev->host->hostt;
> > + int err;
> > +
> > + err = scsi_device_quiesce(sdev);
>
> int err = scsi_device_quiesce()?
Shouldn't matter for the generated code, right?
> > + if (err)
> > + printk(KERN_DEBUG "%s: error (0x%x) during shutdown\n",
> > + __FUNCTION__, err);
>
> If you get an error, and then ignore it... that should not be DEBUG
> message, right?
>
> > + if (sht->shutdown)
> > + sht->shutdown(sdev);
> > +}
> > +
> > struct bus_type scsi_bus_type = {
> > .name = "scsi",
> > .match = scsi_bus_match,
> > .suspend = scsi_bus_suspend,
> > .resume = scsi_bus_resume,
> > + .shutdown = scsi_bus_shutdown,
> > };
>
> Whitespace?
Not a problem in my addition. Are you requesting me to fix
the other lines?
~Randy
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
