On Tue, Feb 28 2006, Jeff Garzik wrote: > Jens Axboe wrote: > >Upstream 2.6.x certainly _does_ care about suspend/resume! To me, this > >patch seems simple enough to be included. It's little more than > >splitting the register init out form the port_stop/start functions and > >calling them on resume/suspend appropriately. > > Upstream _libata_ doesn't care much about suspend/resume. Officially, > its a work in progress with major pieces -- your patch and ACPI -- still > missing. Eh my patch is not missing, it's been merged since the start of 2.6.16-rc. The acpi patch is still missing, however that's not required on all machines. So SATA suspend should work now, at least on ata_piix which is the only driver that currently enables it. For 2.6.15 I agree, we don't care about suspend since it basically cannot work. That's not the case for 2.6.16 though. > Further, good improvements covering some of the changes in Hannes' patch > are already in #upstream. > > Thus, it's more work than its worth to care about the patch as-is. It > should be redone against #upstream, which is where all suspend/resume > development is occurring. I'm sure Hannes will regenerate against upstream as well if necessary, however that depends on when this should be applied. -- Jens Axboe - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
