Re: [PATCH 08/21] drivers: base: Implement weak arch_unregister_cpu()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>, linux-pm@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH 08/21] drivers: base: Implement weak arch_unregister_cpu()
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Fri, 01 Dec 2023 12:06:31 +0100
- Cc: Salil Mehta <salil.mehta@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, jianyong.wu@xxxxxxx, justin.he@xxxxxxx, James Morse <james.morse@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>
- In-reply-to: <E1r5R3H-00CszC-2n@rmk-PC.armlinux.org.uk>
- References: <ZVyz/Ve5pPu8AWoA@shell.armlinux.org.uk> <E1r5R3H-00CszC-2n@rmk-PC.armlinux.org.uk>
On Tue, Nov 21 2023 at 13:44, Russell King wrote:
> ---
> An open question remains from the RFC v2 posting: should we provide a
> __weak stub for !HOTPLUG_CPU as well, since in later patches ACPI may
> reference this if the compiler doesn't optimise as we expect?
You mean:
extern void foo(void);
if (!IS_ENABLED(CONFIG_FOO))
foo();
The kernel uses this pattern for years and if someday a compiler starts
to fail to eliminate the call to 'foo()' for CONFIG_FOO=n then you
already get hundreds linkage fails today.
So adding one more in later patches won't matter much :)
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]