Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Subject: Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Tue, 14 Feb 2023 14:29:44 -0500
Cc: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, jgross@xxxxxxxx, richard.henderson@xxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, mattst88@xxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, guoren@xxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, chenhuacai@xxxxxxxxxx, kernel@xxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, f.fainelli@xxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, tsbogend@xxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, jiaxun.yang@xxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, npiggin@xxxxxxxxx, christophe.leroy@xxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ysato@xxxxxxxxxxxxx, dalias@xxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx, chris@xxxxxxxxxx, jcmvbkbc@xxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, juri.lelli@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, bsegall@xxxxxxxxxx, mgorman@xxxxxxx, bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, paulmck@xxxxxxxxxx
In-reply-to: <20230214182322.r5tyeowxzloiuh72@treble>
References: <cover.1676358308.git.jpoimboe@kernel.org> <cca346b5c87693499e630291d78fb0bf12c24290.1676358308.git.jpoimboe@kernel.org> <1b4afd82-83cb-0060-7cab-8e16d2e69ff9@linaro.org> <20230214182322.r5tyeowxzloiuh72@treble>

On Tue, 14 Feb 2023 10:23:22 -0800
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:


> void __ref cpu_die(void)
> {
> 	idle_task_exit();
> 	local_irq_disable();
> 	__asm__ __volatile__(
> 			"	movi	a2, cpu_restart\n"
> 			"	jx	a2\n");
> 
> 	BUG();
> }
> 
> Hm, not only is the comment wrong, but it seems to be branching to
> cpu_restart?  That doesn't seem right at all.

Agreed, that does not look right at all.

-- Steve

> 
> Max/Chris?
>

References:
- [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn
  - From: Josh Poimboeuf
- [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
  - From: Josh Poimboeuf
- Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
  - From: Philippe Mathieu-Daudé
- Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
  - From: Josh Poimboeuf

Prev by Date: Re: [PATCH v2 03/24] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return
Next by Date: Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
Previous by thread: Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
Next by thread: Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Sparc Linux] [DCCP] [Linux ARM] [Yosemite News] [Linux SCSI] [Linux x86_64] [Linux for Ham Radio]