Re: [PATCH -tip v8 10/13] x86/kprobes: Push a fake return address at kretprobe_trampoline
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
- Subject: Re: [PATCH -tip v8 10/13] x86/kprobes: Push a fake return address at kretprobe_trampoline
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 10:17:26 +0200
- Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, Daniel Xu <dxu@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kuba@xxxxxxxxxx, mingo@xxxxxxxxxx, ast@xxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, kernel-team@xxxxxx, yhs@xxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Abhishek Sagar <sagar.abhishek@xxxxxxxxx>, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
- In-reply-to: <162400001661.506599.5153975410607447958.stgit@devnote2>
- References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162400001661.506599.5153975410607447958.stgit@devnote2>
* Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> + /* Replace fake return address with real one. */
> + *frame_pointer = kretprobe_trampoline_handler(regs, frame_pointer);
> + /*
> + * Move flags to sp so that kretprobe_trapmoline can return
> + * right after popf.
What is a trapmoline?
Also, in the x86 code we capitalize register and instruction names so that
they are more distinctive and easier to read in the flow of English text.
Thanks,
Ingo
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]