Re: [PATCH -tip v8 08/13] arm: kprobes: Make a space for regs->ARM_pc at kretprobe_trampoline
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
- Subject: Re: [PATCH -tip v8 08/13] arm: kprobes: Make a space for regs->ARM_pc at kretprobe_trampoline
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 10:04:41 +0200
- Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, Daniel Xu <dxu@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kuba@xxxxxxxxxx, mingo@xxxxxxxxxx, ast@xxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, kernel-team@xxxxxx, yhs@xxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Abhishek Sagar <sagar.abhishek@xxxxxxxxx>, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
- In-reply-to: <162399999702.506599.16339931387573094059.stgit@devnote2>
- References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399999702.506599.16339931387573094059.stgit@devnote2>
* Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> Change kretprobe_trampoline to make a space for regs->ARM_pc so that
> kretprobe_trampoline_handler can call instruction_pointer_set()
> safely.
The idiom is "make space", but in any case, what does this mean?
Was the stack frame set up in kretprobe_trampoline() and calling
trampoline_handler() buggy?
If yes, then explain the bad effects of the bug, and make all of this clear
in the title & changelog.
Thanks,
Ingo
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
