RE: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: <martin.petersen@xxxxxxxxxx>, <Scott.Teel@xxxxxxxxxxxxx>, <jszczype@xxxxxxxxxx>, <storagedev@xxxxxxxxxxxxx>, <slyfox@xxxxxxxxxx>, <glaubitz@xxxxxxxxxxxxxxxxxxx>, <arnd@xxxxxxxxxx>, <Scott.Benesh@xxxxxxxxxxxxx>, <thenzl@xxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>
- Subject: RE: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
- From: <Don.Brace@xxxxxxxxxxxxx>
- Date: Thu, 15 Apr 2021 18:41:30 +0000
- Accept-language: en-US
- Cc: <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <161733538518.31379.13275738935787597303.b4-ty@oracle.com>
- Ironport-sdr: 3JK0RJ1/oQ4QHHgrGNLrULe1ZYW1EupfQNLrPQVqrvxtYcXMnP7FkGCbVVIZ667ZwyVqjthKG3 GEn+jtSQ0hz6aFa1whRHQVvQ5R2quT3hXQ8HmhVqzEOf9MnOjn0G2y3DWi21gtR9LJzjOBd+Hl vbrmpMIk+chwA+2E+mfJS6TpyzCXiG+WIMMZLQweQBjUFczn1ARJLIOwC7C0ypMkIwuJdTq22M 32jpCFiNaaN5GCJWv4FQt8/C7vuB2ualABIMyjvnUd0+xvd1sPanhM2jgVhKbRInylCpQmPAZ2 wFA=
- References: <yq1wntpgxxr.fsf@ca-mkp.ca.oracle.com> <20210330071958.3788214-1-slyfox@gentoo.org> <161733538518.31379.13275738935787597303.b4-ty@oracle.com>
-----Original Message-----
From: Martin K. Petersen Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
> Some of the structs contain `atomic_t` values and are not intended to
> be sent to IO controller as is.
>
> The change adds __packed to every struct and union in the file.
> Follow-up commits will fix `atomic_t` problems.
>
> The commit is a no-op at least on ia64:
> $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o)
Applied to 5.12/scsi-fixes, thanks!
Don: Thank-you for all of your efforts. I appreciate to work that you have done on these patches.
Thanks,
Don Brace
[1/3] hpsa: use __packed on individual structs, not header-wide
https://git.kernel.org/mkp/scsi/c/5482a9a1a8fd
[2/3] hpsa: fix boot on ia64 (atomic_t alignment)
https://git.kernel.org/mkp/scsi/c/02ec144292bc
[3/3] hpsa: add an assert to prevent from __packed reintroduction
https://git.kernel.org/mkp/scsi/c/e01a00ff62ad
--
Martin K. Petersen Oracle Linux Engineering
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]