Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Scott Teel <scott.teel@xxxxxxxxxxxxx>, jszczype@xxxxxxxxxx, storagedev@xxxxxxxxxxxxx, Don Brace <don.brace@xxxxxxxxxxxxx>, Sergei Trofimovich <slyfox@xxxxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxxxx>, Scott Benesh <scott.benesh@xxxxxxxxxxxxx>, thenzl@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Thu, 1 Apr 2021 23:54:48 -0400
- Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20210330071958.3788214-1-slyfox@gentoo.org>
- References: <yq1wntpgxxr.fsf@ca-mkp.ca.oracle.com> <20210330071958.3788214-1-slyfox@gentoo.org>
On Tue, 30 Mar 2021 08:19:56 +0100, Sergei Trofimovich wrote:
> Some of the structs contain `atomic_t` values and are not intended to be
> sent to IO controller as is.
>
> The change adds __packed to every struct and union in the file.
> Follow-up commits will fix `atomic_t` problems.
>
> The commit is a no-op at least on ia64:
> $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o)
Applied to 5.12/scsi-fixes, thanks!
[1/3] hpsa: use __packed on individual structs, not header-wide
https://git.kernel.org/mkp/scsi/c/5482a9a1a8fd
[2/3] hpsa: fix boot on ia64 (atomic_t alignment)
https://git.kernel.org/mkp/scsi/c/02ec144292bc
[3/3] hpsa: add an assert to prevent from __packed reintroduction
https://git.kernel.org/mkp/scsi/c/e01a00ff62ad
--
Martin K. Petersen Oracle Linux Engineering
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
