RE: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Arnd Bergmann <arnd@xxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
- Subject: RE: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
- From: "Luck, Tony" <tony.luck@xxxxxxxxx>
- Date: Thu, 24 Oct 2019 16:57:28 +0000
- Accept-language: en-US
- Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-rtc@xxxxxxxxxxxxxxx" <linux-rtc@xxxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "Yu, Fenghua" <fenghua.yu@xxxxxxxxx>, "Stephane Eranian" <eranian@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.2.0.6
- In-reply-to: <CAK8P3a2=9dw2YN-sc7yxwwnRi-6Bos32==523qPaqW=avLs60Q@mail.gmail.com>
- References: <20191023150311.844123-1-arnd@arndb.de> <20191023184616.GA17078@agluck-desk2.amr.corp.intel.com> <20191023200135.GT3125@piout.net> <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com> <20191023232004.GV3125@piout.net> <CAK8P3a2=9dw2YN-sc7yxwwnRi-6Bos32==523qPaqW=avLs60Q@mail.gmail.com>
> arch/ia64 has a read_persistent_clock64() function, so it ends up reading
> the system time regardless of the RTC driver or CONFIG_RTC_HCTOSYS.
>
> As ia64 sets neither ARCH_HIBERNATION_POSSIBLE nor
> ARCH_SUSPEND_POSSIBLE, so we could just remove the
> read_persistent_clock64() and efi_gettimeofday(), relying instead
> on user space (/sbin/hwclock) or CONFIG_RTC_HCTOSYS.
Seems weird. ia64 has always assumed from day 1 that it is running
on a UEFI capable platorm (well at day 1 it was called "EFI", the "U"
came later).
So read_persistent_clock64() just calls EFI directly to get the time.
Seems simpler than worrying about having the right drivers and CONFIG
bits set.
-Tony
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]