Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Luck, Tony" <tony.luck@xxxxxxxxx>
- Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
- From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
- Date: Thu, 24 Oct 2019 01:20:04 +0200
- Cc: Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-rtc@xxxxxxxxxxxxxxx" <linux-rtc@xxxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "Yu, Fenghua" <fenghua.yu@xxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com>
- References: <20191023150311.844123-1-arnd@arndb.de> <20191023184616.GA17078@agluck-desk2.amr.corp.intel.com> <20191023200135.GT3125@piout.net> <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com>
- User-agent: Mutt/1.12.1 (2019-06-15)
On 23/10/2019 21:30:29+0000, Luck, Tony wrote:
> >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423)
>
> > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd
> > will not like that but efirtc was not setting the system time anyway so
> > this shouldn't change the behaviour.
>
>
> Wait ... that message says "setting system clock"
>
> but then you say " efirtc was not setting the system time anyway".
>
> So did the time get set, or not?
>
> If it wasn't set, why does the message say that it was set?
>
What I meant was that drivers/char/efirtc.c was not setting the system
time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the
kernel will use the rtc to set the system time.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]