Re: [PATCH v3 02/11] s390x/mm: Fail when an altmap is used for arch_add_memory()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: David Hildenbrand <david@xxxxxxxxxx>
- Subject: Re: [PATCH v3 02/11] s390x/mm: Fail when an altmap is used for arch_add_memory()
- From: Michal Hocko <mhocko@xxxxxxxxxx>
- Date: Mon, 1 Jul 2019 14:46:28 +0200
- Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, Dan Williams <dan.j.williams@xxxxxxxxx>, Wei Yang <richard.weiyang@xxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxxx>
- In-reply-to: <20190701074306.GC6376@dhcp22.suse.cz>
- References: <20190527111152.16324-1-david@redhat.com> <20190527111152.16324-3-david@redhat.com> <20190701074306.GC6376@dhcp22.suse.cz>
- User-agent: Mutt/1.10.1 (2018-07-13)
On Mon 01-07-19 09:43:06, Michal Hocko wrote:
> On Mon 27-05-19 13:11:43, David Hildenbrand wrote:
> > ZONE_DEVICE is not yet supported, fail if an altmap is passed, so we
> > don't forget arch_add_memory()/arch_remove_memory() when unlocking
> > support.
>
> Why do we need this? Sure ZONE_DEVICE is not supported for s390 and so
> might be the case for other arches which support hotplug. I do not see
> much point in adding warning to each of them.
I would drop this one. If there is a strong reason to have something
like that it should come with a better explanation and it can be done on
top.
--
Michal Hocko
SUSE Labs
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
