Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Peter Korsgaard <peter@xxxxxxxxxxxxx>, "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>
- Subject: Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it
- From: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
- Date: Mon, 29 Apr 2019 20:26:51 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, lorenzo.pieralisi@xxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, andrew@xxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, sudeep.holla@xxxxxxx, liviu.dudau@xxxxxxx, linux-mips@xxxxxxxxxxxxxxx, vz@xxxxxxxxx, linux@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, khilman@xxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, slemieux.tyco@xxxxxxxxx, matthias.bgg@xxxxxxxxx, jacmet@xxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
- In-reply-to: <87muk8rg82.fsf@dell.be.48ers.dk>
- Organization: metux IT consult
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-14-git-send-email-info@metux.net> <87muk8rg82.fsf@dell.be.48ers.dk>
- User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
On 29.04.19 17:19, Peter Korsgaard wrote:
>>>>>> "Enrico" == Enrico Weigelt, metux IT consult <info@xxxxxxxxx> writes:
>
> > Fill the struct uart_port->mapsize field and use it, insteaf of
>
> s/insteaf/instead/
Fixed.
> > hardcoded values in many places. This makes the code layout a bit
> > more consistent and easily allows using generic helpers for the
> > io memory handling.
>
> > Candidates for such helpers could be eg. the request+ioremap and
> > iounmap+release combinations.
>
> > Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>
>
> Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
thanks for review.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]