Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Christophe Leroy <christophe.leroy@xxxxxx>, "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls
- From: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
- Date: Mon, 29 Apr 2019 18:20:31 +0200
- Cc: lorenzo.pieralisi@xxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, andrew@xxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, sudeep.holla@xxxxxxx, liviu.dudau@xxxxxxx, linux-mips@xxxxxxxxxxxxxxx, vz@xxxxxxxxx, linux@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, khilman@xxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, slemieux.tyco@xxxxxxxxx, matthias.bgg@xxxxxxxxx, jacmet@xxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
- In-reply-to: <a00ba23b-e73e-c964-a6d0-347cb605b8c8@c-s.fr>
- Organization: metux IT consult
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-23-git-send-email-info@metux.net> <a00ba23b-e73e-c964-a6d0-347cb605b8c8@c-s.fr>
- User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
On 29.04.19 17:59, Christophe Leroy wrote:
> If we want to do something useful, wouldn't it make more sense to
> introduce the use of dev_err() in order to identify the faulting device
> in the message ?
Well, I could get the struct device* pointer via pinfo.port->dev,
but I wasn't entirely sure that it's always defined before these
functions could be called.
Shall I change it to dev_*() ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
