Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>
- Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk()
- From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- Date: Sat, 27 Apr 2019 15:30:50 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, andrew@xxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <1556369542-13247-6-git-send-email-info@metux.net>
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net>
- User-agent: Mutt/1.11.4 (2019-03-13)
On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote:
> Fix the checkpatch warning:
>
> WARNING: printk() should include KERN_<LEVEL> facility level
> #934: FILE: dz.c:934:
> + printk("%s%s\n", dz_name, dz_version);
>
> Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>
> ---
> drivers/tty/serial/dz.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c
> index 559d076..e2670c4 100644
> --- a/drivers/tty/serial/dz.c
> +++ b/drivers/tty/serial/dz.c
> @@ -931,7 +931,7 @@ static int __init dz_init(void)
> if (IOASIC)
> return -ENXIO;
>
> - printk("%s%s\n", dz_name, dz_version);
> + pr_info("%s%s\n", dz_name, dz_version);
Just drop this line, it's not needed and generally just noise.
thanks,
greg k-h
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]