Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: David Hildenbrand <david@xxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE
- From: Anshuman Khandual <anshuman.khandual@xxxxxxx>
- Date: Mon, 26 Nov 2018 19:32:44 +0530
- Cc: ocfs2-devel@xxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, jiangqi903@xxxxxxxxx, hverkuil@xxxxxxxxx, vkoul@xxxxxxxxxx
- In-reply-to: <bcf609de-c60a-d6ad-7acb-6c59c412adbc@redhat.com>
- References: <1543235202-9075-1-git-send-email-anshuman.khandual@arm.com> <bcf609de-c60a-d6ad-7acb-6c59c412adbc@redhat.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 11/26/2018 06:18 PM, David Hildenbrand wrote:
> On 26.11.18 13:26, Anshuman Khandual wrote:
>> At present there are multiple places where invalid node number is encoded
>> as -1. Even though implicitly understood it is always better to have macros
>> in there. Replace these open encodings for an invalid node number with the
>> global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like
>> 'invalid node' from various places redirecting them to a common definition.
>>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
>> ---
>> Changes in V2:
>>
>> - Added inclusion of 'numa.h' header at various places per Andrew
>> - Updated 'dev_to_node' to use NUMA_NO_NODE instead per Vinod
>
> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
Thanks David. My bad, forgot to add your review tag from the earlier version.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]