Hi Mike,Thanks for your review. I'm going to fix the 2nd patch as you said, you're right, no need to move the #include at the bottom of the file.
I'm going to post a v5, add -mm in cc and ask for inclusion in their tree. Thanks again for your time, Alex On 07/26/2018 09:16 PM, Mike Kravetz wrote:
On 07/26/2018 04:46 AM, Michael Ellerman wrote:Mike Kravetz <mike.kravetz@xxxxxxxxxx> writes:On 07/20/2018 11:37 AM, Alex Ghiti wrote:Does anyone have any suggestion about those patches ?I only took a quick look. From the hugetlb perspective, I like the idea of moving routines to a common file. If any of the arch owners (or anyone else) agree, I can do a review of the series.The conversions look pretty good to me. If you want to give it a review then from my point of view it could go in -mm to shake out any bugs.Nothing of significance found in a review. As others have suggested, the (cross)compiler may be better at finding issues than human eyes. I also suggest it be added to -mm.
-- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|