Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Alex Ghiti <alex@xxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>
- Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives
- From: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
- Date: Thu, 26 Jul 2018 12:16:29 -0700
- Cc: linux@xxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, will.deacon@xxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, ralf@xxxxxxxxxxxxxx, paul.burton@xxxxxxxx, jhogan@xxxxxxxxxx, jejb@xxxxxxxxxxxxxxxx, deller@xxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, ysato@xxxxxxxxxxxxxxxxxxxx, dalias@xxxxxxxx, davem@xxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, arnd@xxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>, "Aneesh Kumar K . V" <aneesh.kumar@xxxxxxxxxxxxx>
- In-reply-to: <87tvomgqyv.fsf@concordia.ellerman.id.au>
- References: <20180705110716.3919-1-alex@ghiti.fr> <20180709141621.GD22297@dhcp22.suse.cz> <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> <75195a7d-3d0f-4e55-92cc-4ad772683c75@oracle.com> <87tvomgqyv.fsf@concordia.ellerman.id.au>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 07/26/2018 04:46 AM, Michael Ellerman wrote:
> Mike Kravetz <mike.kravetz@xxxxxxxxxx> writes:
>
>> On 07/20/2018 11:37 AM, Alex Ghiti wrote:
>>> Does anyone have any suggestion about those patches ?
>>
>> I only took a quick look. From the hugetlb perspective, I like the
>> idea of moving routines to a common file. If any of the arch owners
>> (or anyone else) agree, I can do a review of the series.
>
> The conversions look pretty good to me. If you want to give it a review
> then from my point of view it could go in -mm to shake out any bugs.
Nothing of significance found in a review. As others have suggested,
the (cross)compiler may be better at finding issues than human eyes.
I also suggest it be added to -mm.
--
Mike Kravetz
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
