Re: [PATCH 2/2] kallsyms: handle special absolute symbols
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Kees Cook <keescook@xxxxxxxxxxxx>
- Subject: Re: [PATCH 2/2] kallsyms: handle special absolute symbols
- From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
- Date: Fri, 07 Mar 2014 13:55:00 +1030
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Andrew Honig <ahonig@xxxxxxxxxx>, Michal Marek <mmarek@xxxxxxx>, "x86\@kernel.org" <x86@xxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, keescook@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <1394152324-26304-3-git-send-email-keescook@chromium.org>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1394152324-26304-1-git-send-email-keescook@chromium.org> <1394152324-26304-3-git-send-email-keescook@chromium.org>
- User-agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu)
Kees Cook <keescook@xxxxxxxxxxxx> writes:
> This forces the entire per_cpu range to be reported as absolute without
> losing their linker symbol types. Without this, the variables are
> incorrectly shown as relocated under kASLR.
I like these patches, thanks!
This one's a bit broken, since the zero-based __per_cpu_start/end thing
is an x86-64-ism. You really do want them relocated on other
platforms, so I think you'll need do make this conditional via
a --per-cpu-absolute flag to kallsyms (which x86-64 would set).
Dumb Q: why don't we actually present these symbols as absolute in
/proc/kallsyms? Seems like it would be clearer...
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]