Re: [BUGFIX PATCH][RESEND] kexec & iosapic: kexec oops when iosapic was removed
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Luck, Tony" <tony.luck@xxxxxxxxx>
- Subject: Re: [BUGFIX PATCH][RESEND] kexec & iosapic: kexec oops when iosapic was removed
- From: Hanjun Guo <guohanjun@xxxxxxxxxx>
- Date: Thu, 16 Aug 2012 18:28:08 +0800
- Cc: "Yu, Fenghua" <fenghua.yu@xxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Jiang Liu <jiang.liu@xxxxxxxxxx>, Eric Biederman <ebiederm@xxxxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Haren Myneni <hbabu@xxxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>, Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>, Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Tang Chen <tangchen@xxxxxxxxxxxxxx>, Jianguo Wu <wujianguo@xxxxxxxxxx>
- In-reply-to: <3908561D78D1C84285E8C5FCA982C28F19375F30@ORSMSX104.amr.corp.intel.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1344583395-9128-1-git-send-email-guohanjun@huawei.com> <5025CD41.2030502@huawei.com> <3908561D78D1C84285E8C5FCA982C28F19375F30@ORSMSX104.amr.corp.intel.com>
- User-agent: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20120713 Thunderbird/14.0
On 2012/8/13 10:54, Luck, Tony wrote:
>> vec = irq_to_vector(irq);
>> list_for_each_entry(rte, &info->rtes,
>> rte_list) {
>> + if (rte->refcnt == NO_REF_RTE)
>> + continue;
>> +
>> iosapic_write(rte->iosapic,
>> IOSAPIC_RTE_LOW(rte->rte_index),
>> IOSAPIC_MASK|vec);
>
> This will work - but is it papering over a problem when you removed the
> iosapic? Should we really have removed this "rte" from rte_list when the
> iosapic was removed?
>
> -Tony
>
Hi Tony,
Thanks for your comments, and sorry for the late reply.
We only set rte->refcnt to NO_REF_RTE if no device attach to this RTE when
unregister a GSI, and increase the rte->refcnt if the RTE is already existing
when register a GSI, so "rte" will not removed from rte_list when the
iosapic is removed.
Actually, the rte_list will keep static when remove/add a existing iosapic
after boot up.
Should we remove the RTE from the rte_list? if yes, we will have more
to do than this patch.
Thanks
Hanjun Guo
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]