RE: [BUGFIX PATCH][RESEND] kexec & iosapic: kexec oops when iosapic was removed
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Hanjun Guo <guohanjun@xxxxxxxxxx>, "Yu, Fenghua" <fenghua.yu@xxxxxxxxx>
- Subject: RE: [BUGFIX PATCH][RESEND] kexec & iosapic: kexec oops when iosapic was removed
- From: "Luck, Tony" <tony.luck@xxxxxxxxx>
- Date: Mon, 13 Aug 2012 02:54:09 +0000
- Accept-language: en-US
- Cc: "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Jiang Liu <jiang.liu@xxxxxxxxxx>, Eric Biederman <ebiederm@xxxxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Haren Myneni <hbabu@xxxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>, Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>, Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Tang Chen <tangchen@xxxxxxxxxxxxxx>, Jianguo Wu <wujianguo@xxxxxxxxxx>
- In-reply-to: <5025CD41.2030502@huawei.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1344583395-9128-1-git-send-email-guohanjun@huawei.com> <5025CD41.2030502@huawei.com>
- Thread-index: AQHNeP7pGYh1bPuB1UibjB7tcU+h4g==
- Thread-topic: [BUGFIX PATCH][RESEND] kexec & iosapic: kexec oops when iosapic was removed
> vec = irq_to_vector(irq);
> list_for_each_entry(rte, &info->rtes,
> rte_list) {
> + if (rte->refcnt == NO_REF_RTE)
> + continue;
> +
> iosapic_write(rte->iosapic,
> IOSAPIC_RTE_LOW(rte->rte_index),
> IOSAPIC_MASK|vec);
This will work - but is it papering over a problem when you removed the
iosapic? Should we really have removed this "rte" from rte_list when the
iosapic was removed?
-Tony
.
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]