Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Eric Paris <eparis@xxxxxxxxxx>
- Subject: Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
- From: Richard Weinberger <richard@xxxxxx>
- Date: Fri, 3 Jun 2011 00:32:16 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, monstr@xxxxxxxxx, ralf@xxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, linux390@xxxxxxxxxx, lethal@xxxxxxxxxxxx, davem@xxxxxxxxxxxxx, jdike@xxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, oleg@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, microblaze-uclinux@xxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <20110602210458.23613.24076.stgit@xxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20110602210458.23613.24076.stgit@xxxxxxxxxxxxxxxxxxxx>
- User-agent: KMail/1.13.7 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.3; x86_64; ; )
Am Donnerstag 02 Juni 2011, 23:04:58 schrieb Eric Paris:
> b/arch/um/sys-i386/shared/sysdep/ptrace.h index d50e62e..ef5c310 100644
> --- a/arch/um/sys-i386/shared/sysdep/ptrace.h
> +++ b/arch/um/sys-i386/shared/sysdep/ptrace.h
> @@ -162,6 +162,7 @@ struct syscall_args {
> #define UPT_ORIG_SYSCALL(r) UPT_EAX(r)
> #define UPT_SYSCALL_NR(r) UPT_ORIG_EAX(r)
> #define UPT_SYSCALL_RET(r) UPT_EAX(r)
> +#define regs_return_value UPT_SYSCALL_RET
This does not work at all.
UPT_SYSCALL_RET expects something of type struct uml_pt_regs.
#define regs_return_value REGS_EAX
Would be correct. (For x86_64 it needs to be REGS_RAX)
But there seems to be another problem.
Why is pt_regs of type void *?
gcc complains:
In file included from include/linux/fsnotify.h:15:0,
from include/linux/security.h:26,
from init/main.c:32:
include/linux/audit.h: In function âaudit_syscall_exitâ:
include/linux/audit.h:440:17: warning: dereferencing âvoid *â pointer
include/linux/audit.h:440:3: error: invalid use of void expression
include/linux/audit.h:441:21: warning: dereferencing âvoid *â pointer
include/linux/audit.h:441:21: error: void value not ignored as it ought to be
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]