Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Eric Paris <eparis@xxxxxxxxxx>
- Subject: Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
- From: "H. Peter Anvin" <hpa@xxxxxxxxx>
- Date: Thu, 02 Jun 2011 14:18:34 -0700
- Cc: linux-kernel@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, monstr@xxxxxxxxx, ralf@xxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, linux390@xxxxxxxxxx, lethal@xxxxxxxxxxxx, davem@xxxxxxxxxxxxx, jdike@xxxxxxxxxxx, richard@xxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, x86@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, oleg@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, microblaze-uclinux@xxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <20110602210458.23613.24076.stgit@xxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20110602210458.23613.24076.stgit@xxxxxxxxxxxxxxxxxxxx>
- User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10
On 06/02/2011 02:04 PM, Eric Paris wrote:
> The audit system previously expected arches calling to audit_syscall_exit to
> supply as arguments if the syscall was a success and what the return code was.
> Audit also provides a helper AUDITSC_RESULT which was supposed to simplify by
> converting from negative retcodes to an audit internal magic value stating
> success or failure. This helper was wrong and could indicate that a valid
> pointer returned to userspace was a failed syscall. The fix is to fix the
> layering foolishness. We now pass audit_syscall_exit a struct pt_reg and it
> in turns calls back into arch code to collect the return value and to
> determine if the syscall was a success or failure.
>
> In arch/sh/kernel/ptrace_64.c I see that we were using regs[9] in the old
> audit code. But the ptrace_64.h code was previously using regs[3] for the
> regs_return_value(). I have no idea which one is correct, but this patch now
> uses regs[3].
>
> Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
For the x86 portions:
Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]