On 10/20/2009 02:27 AM, Jiri Kosina wrote:
> @@ -1627,11 +1623,10 @@ static int tg_shares_up(struct task_group *tg, void *data)
> return 0;
>
> local_irq_save(flags);
> - usd = &__get_cpu_var(update_shares_data);
>
> for_each_cpu(i, sched_domain_span(sd)) {
> weight = tg->cfs_rq[i]->load.weight;
> - usd->rq_weight[i] = weight;
> + usd = *per_cpu_ptr(update_shares_data, i) = weight;
>
> /*
> * If there are currently no tasks on the cpu pretend there
I don't think this is what you want here.
In the original version, usd is the percpu var using the current cpu. In
your version, usd is the percpu var using i instead of the current cpu.
I'll post my version of the patch shortly. I don't think keeping most of
the original version is a bad thing. We can just allocate it dynamically
instead.
-Jeff
--
Jeff Mahoney
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|