[PATCH v2 2/2] ia64: Remove redundant cpu_clear() in __cpu_disable path
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: tony.luck@xxxxxxxxx, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>, stable@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
- Subject: [PATCH v2 2/2] ia64: Remove redundant cpu_clear() in __cpu_disable path
- From: Alex Chiang <achiang@xxxxxx>
- Date: Mon, 9 Feb 2009 11:16:57 -0700
- In-reply-to: <20090209181338.GD19064@xxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- Mail-followup-to: Alex Chiang <achiang@xxxxxx>, tony.luck@xxxxxxxxx, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>, stable@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
- References: <20090209181338.GD19064@xxxxxxxxxxxxx>
- User-agent: Mutt/1.5.17+20080114 (2008-01-14)
The second call to cpu_clear() is redundant, as we've already removed
the CPU from cpu_online_map before calling migrate_platform_irqs().
Cc: stable@xxxxxxxxxx
Signed-off-by: Alex Chiang <achiang@xxxxxx>
---
arch/ia64/kernel/smpboot.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index 2ec5bbf..5229054 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -740,11 +740,10 @@ int __cpu_disable(void)
if (migrate_platform_irqs(cpu)) {
cpu_set(cpu, cpu_online_map);
- return (-EBUSY);
+ return -EBUSY;
}
remove_siblinginfo(cpu);
- cpu_clear(cpu, cpu_online_map);
fixup_irqs();
local_flush_tlb_all();
cpu_clear(cpu, cpu_callin_map);
--
1.6.0.1.161.g7f314
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]