On 29.04.08 09:42:18, Arjan van de Ven wrote: > On Wed, 30 Apr 2008 15:51:39 +0200 > "stephane eranian" <eranian@xxxxxxxxxxxxxx> wrote: > > > If I recall, AMD said that this special initialization would > > eventually migrate into the core kernel. The pci_read() may be there > > because it was not exported by the kernel (this particular code lives > > in a kernel module). > > ... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird. > > I find it hard to believe that there would be no code in the kernel to > read or write config space of a device you have..... :) > In fact I bet 80% of the drivers in the tree use it. Access to extended config space for AMD northbridges was not yet implemented. Recent patches from Yinghai Lu fix this. I will send a patch that uses the in-kernel functions. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |