Christoph Hellwig wrote:
On Thu, Apr 19, 2007 at 01:58:44AM -0600, Eric W. Biederman wrote:From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> This patch starts the xpc kernel threads using kthread_run not a combination of kernel_thread and daemonize. Resuling in slightly simpler and more maintainable code.This driver is a really twisted maze. It has a lot of threads, some of them running through the whole lifetime of the driver, some short-lived and some in a sort of a pool. The patch below fixes up the long-lived thread as well as fixing gazillions of leaks in the init routine by switching to proper goto-based unwinding. Note that thread pools are something we have in a few places, and might be worth handling in the core kthread infrastructure, as tearing down pools will get a bit complicated using the kthread APIs.
Like with the previous patch from Eric, I'm CC'ing the correct people for this patch (forwarded it in a seperate email). CC'ing irrelevant lists such as containers@ and not linux-ia64@ makes it somewhat difficult to get proper reviews of these things. Russ/Dean/Robin - could one of you provide some feedback to this one please. Thanks, Jes - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |