Re: [PATCH] Fix NULL-pointer dereference in ia64_machine_kexec()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bernhard Walle wrote:
Hello Jes,

* Jes Sorensen <jes@xxxxxxx> [2007-01-27 07:28]:
"Bernhard" == Bernhard Walle <bwalle@xxxxxxx> writes:
Bernhard> printk(KERN_NOTICE "Kdump not configured\n");

Wouldn't it make more sense to make that messages a bit more
descriptive? Ie. include something about what it tried to do when it
noticed it wasn't configured?

Do you think
    machine_kdump_on_init(): kdump not configured

would be better? That would make it easier to find the position of the
message in code. Or did you think of a more verbal description like

That would do just fine I think, anything to avoid having to run find
and grep on the tree to figure out where it came from :)

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux