Hello Jes,
* Jes Sorensen <jes@xxxxxxx> [2007-01-27 07:28]:
> >>>>> "Bernhard" == Bernhard Walle <bwalle@xxxxxxx> writes:
>
> Bernhard> printk(KERN_NOTICE "Kdump not configured\n");
>
> Wouldn't it make more sense to make that messages a bit more
> descriptive? Ie. include something about what it tried to do when it
> noticed it wasn't configured?
Do you think
machine_kdump_on_init(): kdump not configured
would be better? That would make it easier to find the position of the
message in code. Or did you think of a more verbal description like
tried to dump but that's not possible because kdump was
not configured (ia64_kimage == NULL)
But I think we shouldn't write novels in the kernel log. ;)
But feel free to suggest another proposal and I'll update the patch. I
just want to see it included in mainline.
Regards,
Bernhard
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|