On Mon, Sep 04, 2006 at 10:05:30AM +0200, Jes Sorensen wrote: > Horms wrote: > > Which I believe is because nodedata.h is not included, as per > > ~line 83 of include/asm/processor.h > > > > #ifdef CONFIG_NUMA > > #include <asm/nodedata.h> > > #endif > > > > Including nodedata.h doesn't seem appropriate, as it does seem to > > be numa-specific. I wasn't able to find an alternate definition of > > CONFIG_NUMA > > IMHO nodedata.h should provide alternative macros for non NUMA builds. > It seems silly to protect the include with #ifdef. That is pretty much what I was thinking. But perhaps there is a reason for it. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ -- VGER BF report: U 0.753438 - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|