Re: [PATCH] panic_on_oops: remove ssleep()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] panic_on_oops: remove ssleep()
- From: Horms <horms@xxxxxxxxxxxx>
- Date: Tue, 18 Jul 2006 15:15:00 -0400
- Cc: linuxppc-dev <linuxppc-dev@xxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Russell King <rmk@xxxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Anton Blanchard <anton@xxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-ia64 <linux-ia64@xxxxxxxxxxxxxxx>, discuss@xxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <200607172126_MC3-1-C544-E35A@xxxxxxxxxxxxxx>
- References: <200607172126_MC3-1-C544-E35A@xxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.11+cvs20060403
On Mon, Jul 17, 2006 at 09:22:17PM -0400, Chuck Ebbert wrote:
> In-Reply-To: <31687.FP.7244@xxxxxxxxxxxx>
>
> On Mon, 17 Jul 2006 12:17:20 -0400, Horms wrote:
>
> > This patch is part of an effort to unify the panic_on_oops behaviour
> > across all architectures that implement it.
> >
> > It was pointed out to me by Andi Kleen that if an oops has occured
> > in interrupt context, then calling sleep() in the oops path will only cause
> > a panic, and that it would be really better for it not to be in the path at
> > all.
>
> i386 already checks in_interrupt() and panics immediately:
Very good point. I guess that needs to be moved to after
panic_on_oops() if the change that Andi suggests works out.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
-
: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]