In-Reply-To: <31687.FP.7244@xxxxxxxxxxxx> On Mon, 17 Jul 2006 12:17:20 -0400, Horms wrote: > This patch is part of an effort to unify the panic_on_oops behaviour > across all architectures that implement it. > > It was pointed out to me by Andi Kleen that if an oops has occured > in interrupt context, then calling sleep() in the oops path will only cause > a panic, and that it would be really better for it not to be in the path at > all. i386 already checks in_interrupt() and panics immediately: --- a/arch/i386/kernel/traps.c +++ b/arch/i386/kernel/traps.c @@ -442,11 +442,9 @@ #endif ===> if (in_interrupt()) ===> panic("Fatal exception in interrupt"); - if (panic_on_oops) { - printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n"); - ssleep(5); - panic("Fatal exception"); - } + if (panic_on_oops) + panic("Fatal exception: panic_on_oops"); + oops_exit(); do_exit(SIGSEGV); } -- Chuck And did we tell you the name of the game, boy, we call it Riding the Gravy Train. - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |