Re: 2.6.17-rc1-mm1
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
- Subject: Re: 2.6.17-rc1-mm1
- From: Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>
- Date: Thu, 6 Apr 2006 11:21:54 +0100
- Cc: "Luck, Tony" <tony.luck@xxxxxxxxx>, Zou Nan hai <nanhai.zou@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <200604051601.08776.bjorn.helgaas@xxxxxx>
- Mail-followup-to: Bjorn Helgaas <bjorn.helgaas@xxxxxx>, "Luck, Tony" <tony.luck@xxxxxxxxx>, Zou Nan hai <nanhai.zou@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- References: <20060404014504.564bf45a.akpm@xxxxxxxx> <200604051015.34217.bjorn.helgaas@xxxxxx> <20060405211757.GA8536@xxxxxxxxxxxxxxxxxxxxxxxxx> <200604051601.08776.bjorn.helgaas@xxxxxx>
- User-agent: Mutt/1.4.1i
On Wed, Apr 05, 2006 at 04:01:08PM -0600, Bjorn Helgaas wrote:
> [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use
Ah, seems to be what I just suggested...
> @@ -1020,14 +1019,14 @@
> char *charmap;
>
> if (vga_video_type != VIDEO_TYPE_EGAM) {
> - charmap = (char *) VGA_MAP_MEM(colourmap);
> + charmap = (char *) VGA_MAP_MEM(colourmap, 0);
Don't like this though - can't we pass a real size here rather than zero?
There seems to be several clues as to the maximum size:
#define cmapsz 8192
if (!vga_font_is_default)
charmap += 4 * cmapsz;
charmap += 2 * cmapsz;
for (i = 0; i < cmapsz; i++)
vga_writeb(arg[i], charmap + i);
so that's about 7 * cmapsz - call that 8 for completeness, which is 64K.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]