On Wed, Apr 05, 2006 at 02:17:57PM -0700, Luck, Tony wrote: > On Wed, Apr 05, 2006 at 10:15:34AM -0600, Bjorn Helgaas wrote: > > Huh. Intel firmware used to just not mention the VGA framebuffer > > (0xa0000-0xc0000) at all in the EFI memory map. I think that was > > clearly a bug. So maybe they fixed that by marking it WB (and > > hopefully UC as well). > > Nope ... not fixed (at least not in the f/w that I'm running). The > VGA buffer is still simply not mentioned in the EFI memory map. > > The problem looks to come from this code in vgacon.c: > > vga_vram_base = VGA_MAP_MEM(vga_vram_base); > vga_vram_end = VGA_MAP_MEM(vga_vram_end); > vga_vram_size = vga_vram_end - vga_vram_base; Wouldn't it be better to do: vga_vram_size = vga_vram_end - vga_vram_base; vga_vram_base = VGA_IOREMAP(vga_vram_base, vga_vram_size); vga_vram_end = vga_vram_base + vga_vram_size; and for compatibility: #define VGA_IOREMAP(base,size) VGA_MAP_MEM(base) ? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|