On Mon, Mar 20, 2006 at 01:36:38PM -0600, Mark Maule wrote: > Index: maule/drivers/pci/Makefile > =================================================================== > --- maule.orig/drivers/pci/Makefile 2006-03-20 11:07:30.602099680 -0600 > +++ maule/drivers/pci/Makefile 2006-03-20 11:08:08.130604825 -0600 > @@ -26,7 +26,19 @@ > obj-$(CONFIG_PPC64) += setup-bus.o > obj-$(CONFIG_MIPS) += setup-bus.o setup-irq.o > obj-$(CONFIG_X86_VISWS) += setup-irq.o > -obj-$(CONFIG_PCI_MSI) += msi.o msi-apic.o > + > +ifdef CONFIG_PCI_MSI > +obj-y += msi.o msi-apic.o > + > +ifdef CONFIG_IA64_GENERIC > +obj-y += msi-altix.o > +else > +ifdef CONFIG_IA64_SGI_SN2 > +obj-y += msi-altix.o > +endif > +endif > + > +endif #CONFIG_PCI_MSI The right way to do this kind of Makefile jiggery-pokery is: msi-y := msi.o msi-apic.o msi-$(CONFIG_IA64_GENERIC) += msi-altix.o msi-$(CONFIG_IA64_SGI_SN2) += msi-altix.o obj-$(CONFIG_PCI_MSI) += $(msi-y) yay for declarative programming ;-) - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |