Hi Aryan, kernel test robot noticed the following build warnings: [auto build test WARNING on andi-shyti/i2c/i2c-host] [also build test WARNING on next-20250312] [cannot apply to linus/master v6.14-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aryan-Srivastava/i2c-octeon-fix-return-commenting/20250311-103714 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20250311023435.3962466-4-aryan.srivastava%40alliedtelesis.co.nz patch subject: [PATCH v12 3/3] i2c: octeon: add block-mode i2c operations config: alpha-randconfig-r132-20250312 (https://download.01.org/0day-ci/archive/20250313/202503130610.rUb3f7P4-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 14.2.0 reproduce: (https://download.01.org/0day-ci/archive/20250313/202503130610.rUb3f7P4-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202503130610.rUb3f7P4-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> drivers/i2c/busses/i2c-octeon-core.c:677:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned long long [usertype] rd @@ got restricted __be64 [usertype] @@ drivers/i2c/busses/i2c-octeon-core.c:677:26: sparse: expected unsigned long long [usertype] rd drivers/i2c/busses/i2c-octeon-core.c:677:26: sparse: got restricted __be64 [usertype] >> drivers/i2c/busses/i2c-octeon-core.c:728:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [addressable] [usertype] buf @@ got restricted __be64 [usertype] @@ drivers/i2c/busses/i2c-octeon-core.c:728:21: sparse: expected unsigned long long [addressable] [usertype] buf drivers/i2c/busses/i2c-octeon-core.c:728:21: sparse: got restricted __be64 [usertype] vim +677 drivers/i2c/busses/i2c-octeon-core.c 633 634 /** 635 * octeon_i2c_hlc_block_comp_read - high-level-controller composite block read 636 * @i2c: The struct octeon_i2c 637 * @msgs: msg[0] contains address, place read data into msg[1] 638 * 639 * i2c core command is constructed and written into the SW_TWSI register. 640 * The execution of the command will result in requested data being 641 * placed into a FIFO buffer, ready to be read. 642 * Used in the case where the i2c xfer is for greater than 8 bytes of read data. 643 * 644 * Returns: 0 on success, otherwise a negative errno. 645 */ 646 static int octeon_i2c_hlc_block_comp_read(struct octeon_i2c *i2c, struct i2c_msg *msgs) 647 { 648 int ret = 0; 649 u16 len; 650 u64 cmd; 651 652 octeon_i2c_hlc_enable(i2c); 653 octeon_i2c_block_enable(i2c); 654 655 /* Write (size - 1) into block control register */ 656 len = msgs[1].len - 1; 657 octeon_i2c_writeq_flush((u64)(len), i2c->twsi_base + OCTEON_REG_BLOCK_CTL(i2c)); 658 659 /* Prepare core command */ 660 cmd = SW_TWSI_V | SW_TWSI_R | SW_TWSI_SOVR | SW_TWSI_OP_7_IA; 661 cmd |= (u64)(msgs[0].addr & 0x7full) << SW_TWSI_ADDR_SHIFT; 662 663 /* Send core command */ 664 ret = octeon_i2c_hlc_read_cmd(i2c, msgs[0], cmd); 665 if (ret) 666 return ret; 667 668 cmd = __raw_readq(i2c->twsi_base + OCTEON_REG_SW_TWSI(i2c)); 669 if ((cmd & SW_TWSI_R) == 0) 670 return octeon_i2c_check_status(i2c, false); 671 672 /* read data in FIFO */ 673 octeon_i2c_writeq_flush(TWSX_BLOCK_STS_RESET_PTR, 674 i2c->twsi_base + OCTEON_REG_BLOCK_STS(i2c)); 675 for (u16 i = 0; i <= len; i += 8) { 676 /* Byte-swap FIFO data and copy into msg buffer */ > 677 u64 rd = cpu_to_be64(__raw_readq(i2c->twsi_base + OCTEON_REG_BLOCK_FIFO(i2c))); 678 679 memcpy(&msgs[1].buf[i], &rd, MIN_T(u16, 8, msgs[1].len - i)); 680 } 681 682 octeon_i2c_block_disable(i2c); 683 return ret; 684 } 685 686 /** 687 * octeon_i2c_hlc_block_comp_write - high-level-controller composite block write 688 * @i2c: The struct octeon_i2c 689 * @msgs: msg[0] contains address, msg[1] contains data to be written 690 * 691 * i2c core command is constructed and write data is written into the FIFO buffer. 692 * The execution of the command will result in HW write, using the data in FIFO. 693 * Used in the case where the i2c xfer is for greater than 8 bytes of write data. 694 * 695 * Returns: 0 on success, otherwise a negative errno. 696 */ 697 static int octeon_i2c_hlc_block_comp_write(struct octeon_i2c *i2c, struct i2c_msg *msgs) 698 { 699 bool set_ext = false; 700 int ret = 0; 701 u16 len; 702 u64 cmd, ext = 0; 703 704 octeon_i2c_hlc_enable(i2c); 705 octeon_i2c_block_enable(i2c); 706 707 /* Write (size - 1) into block control register */ 708 len = msgs[1].len - 1; 709 octeon_i2c_writeq_flush((u64)(len), i2c->twsi_base + OCTEON_REG_BLOCK_CTL(i2c)); 710 711 /* Prepare core command */ 712 cmd = SW_TWSI_V | SW_TWSI_SOVR | SW_TWSI_OP_7_IA; 713 cmd |= (u64)(msgs[0].addr & 0x7full) << SW_TWSI_ADDR_SHIFT; 714 715 /* Set parameters for extended message (if required) */ 716 set_ext = octeon_i2c_hlc_ext(i2c, msgs[0], &cmd, &ext); 717 718 /* Write msg into FIFO buffer */ 719 octeon_i2c_writeq_flush(TWSX_BLOCK_STS_RESET_PTR, 720 i2c->twsi_base + OCTEON_REG_BLOCK_STS(i2c)); 721 for (u16 i = 0; i <= len; i += 8) { 722 u64 buf = 0; 723 724 /* Copy 8 bytes or remaining bytes from message buffer */ 725 memcpy(&buf, &msgs[1].buf[i], MIN_T(u16, 8, msgs[1].len - i)); 726 727 /* Byte-swap message data and write into FIFO */ > 728 buf = cpu_to_be64(buf); 729 octeon_i2c_writeq_flush(buf, i2c->twsi_base + OCTEON_REG_BLOCK_FIFO(i2c)); 730 } 731 if (set_ext) 732 octeon_i2c_writeq_flush(ext, i2c->twsi_base + OCTEON_REG_SW_TWSI_EXT(i2c)); 733 734 /* Send command to core (send data in FIFO) */ 735 ret = octeon_i2c_hlc_cmd_send(i2c, cmd); 736 if (ret) 737 return ret; 738 739 cmd = __raw_readq(i2c->twsi_base + OCTEON_REG_SW_TWSI(i2c)); 740 if ((cmd & SW_TWSI_R) == 0) 741 return octeon_i2c_check_status(i2c, false); 742 743 octeon_i2c_block_disable(i2c); 744 return ret; 745 } 746 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
